Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependsOn example, plus. #12

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dmuylwyk
Copy link

@dmuylwyk dmuylwyk commented Oct 3, 2024

Update dependsOn example, make scripts executable on Linux, and add publisher.jar to gitignore.

Before:

before

After:

after

@dmuylwyk dmuylwyk added the documentation Improvements or additions to documentation label Oct 3, 2024
@dmuylwyk dmuylwyk self-assigned this Oct 3, 2024
Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the shell scripts empty?

@dmuylwyk
Copy link
Author

dmuylwyk commented Oct 3, 2024

Why are the shell scripts empty?

@brynrhodes, they aren't empty. I simply changed the permissions on those files to make them executable. The "empty file" that GitHub references is the diff because there are no changes to the file's contents. I believe you'd see the same if you simply changed a filename and not the contents. If you look at those files in this branch, you'll see the content is unchanged.

Screenshot from 2024-10-03 16-08-58

i.e. 644 -> 755 or -rw-rw-r-- -> -rwxrwxr-x

I needed to run _updatePublisher.sh and _genonce.sh to validate my changes.

@dmuylwyk
Copy link
Author

dmuylwyk commented Oct 4, 2024

Discussed with @brynrhodes out-of-band. Permissions changes to scripts need to be done at source so they aren't undone with future executions of _updatePublisher. Believe this change needs to be made in this project:

https://github.com/FHIR/sample-ig

input/pagecontent/index.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants